-
Notifications
You must be signed in to change notification settings - Fork 0
[OpenAPI] Spec updates for keycloak-api #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 64a3624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
25e4c4d to
d2a09e7
Compare
d2a09e7 to
7f4dc95
Compare
7f4dc95 to
71fe394
Compare
71fe394 to
c94a468
Compare
c94a468 to
df2b2b1
Compare
df2b2b1 to
71d7b84
Compare
| on?: void; | ||
| ["reset-on"]?: void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| on?: void; | |
| ["reset-on"]?: void; | |
| on?: unknown; | |
| ["reset-on"]?: unknown; |
The on and reset-on properties in WorkflowRepresentation are typed as void, which means they cannot hold any meaningful data and can only be undefined.
View Details
Analysis
WorkflowRepresentation properties typed as void prevent workflow configuration
What fails: WorkflowRepresentation.on and WorkflowRepresentation["reset-on"] are typed as void instead of unknown, preventing assignment of workflow event configuration values
How to reproduce:
import { WorkflowRepresentation } from './packages/keycloak-api/src/admin/schemas';
const workflow: WorkflowRepresentation = {
id: "test",
on: "some-event", // TypeScript error: Type 'string' is not assignable to type 'void'
"reset-on": ["event1", "event2"] // TypeScript error: Type 'string[]' is not assignable to type 'void'
};Result: TypeScript compilation fails with "Type 'string' is not assignable to type 'void'" errors
Expected: Properties should accept any values since the Keycloak OpenAPI spec defines them as {} (empty object/any type), similar to how other event properties like onValues and onEventsReset are properly typed as string[]
71d7b84 to
647a584
Compare
647a584 to
cb83154
Compare
cb83154 to
3254200
Compare
3254200 to
8a133f5
Compare
8a133f5 to
544b950
Compare
544b950 to
8b74b58
Compare
3b4d27c to
c2048d4
Compare
c2048d4 to
a859554
Compare
a859554 to
e7f8eba
Compare
e7f8eba to
5dd006d
Compare
5dd006d to
774e499
Compare
774e499 to
e4a6630
Compare
e4a6630 to
0bcebf8
Compare
0bcebf8 to
14f7ef1
Compare
14f7ef1 to
bff1e1d
Compare
bff1e1d to
781f0dc
Compare
781f0dc to
1244786
Compare
1244786 to
2717ace
Compare
2717ace to
310b32c
Compare
310b32c to
29e947e
Compare
29e947e to
64a3624
Compare
This is an autogenerated PR to update the OpenAPI spec with the latest merged changes.
Before merging these changes, please review the update and test it out.